Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: replace echart library and load it modular #645

Merged
merged 9 commits into from
Feb 17, 2022
Merged

perf: replace echart library and load it modular #645

merged 9 commits into from
Feb 17, 2022

Conversation

pataar
Copy link
Member

@pataar pataar commented Feb 16, 2022

This way only the components and renderers are loaded which are used. This'll keep the bundle size smaller.

@pataar pataar marked this pull request as draft February 16, 2022 10:55
@meteyou meteyou added the analyze runs build size report label Feb 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2022

Size Change: -201 kB (-10%) 👏

Total Size: 1.77 MB

Filename Size Change
./dist/assets/Codemirror.js 113 kB +47 B (0%)
./dist/assets/Heightmap.js 120 kB -51.8 kB (-30%) 🎉
./dist/assets/index.js 246 kB +27 B (0%)
./dist/assets/vendor.js 436 kB -149 kB (-25%) 🎉
./dist/assets/Viewer.js 282 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/Codemirror.css 20 B
./dist/assets/Heightmap.css 74 B
./dist/assets/index.css 56.4 kB
./dist/assets/materialdesignicons-webfont.woff2 354 kB
./dist/assets/vendor.css 64.5 kB
./dist/assets/Viewer.css 318 B
./dist/config.json 25 B
./dist/fonts/roboto-black.woff2 11 kB
./dist/fonts/roboto-bold.woff2 11 kB
./dist/fonts/roboto-light.woff2 11.2 kB
./dist/fonts/roboto-medium.woff2 11.1 kB
./dist/fonts/roboto-regular.woff2 11 kB
./dist/fonts/roboto-thin.woff2 11 kB
./dist/img/icons/apple-touch-icon-152x152.png 4.38 kB
./dist/img/icons/favicon-16x16.png 569 B
./dist/img/icons/favicon-32x32.png 1.05 kB
./dist/img/icons/icon-196-png 3.97 kB
./dist/img/icons/icon-512-png 11.1 kB
./dist/img/icons/mstile-150x150.png 4.26 kB
./dist/img/klipper.svg 3.4 kB
./dist/img/logo.svg 4.08 kB
./dist/img/sidebar-background.svg 1.33 kB
./dist/index.html 650 B

compressed-size-action

@github-actions github-actions bot removed the analyze runs build size report label Feb 16, 2022
@pataar pataar added the analyze runs build size report label Feb 16, 2022
@github-actions github-actions bot removed the analyze runs build size report label Feb 16, 2022
@pataar pataar marked this pull request as ready for review February 17, 2022 14:11
@pataar pataar added the analyze runs build size report label Feb 17, 2022
@github-actions github-actions bot removed the analyze runs build size report label Feb 17, 2022
@pataar pataar added the analyze runs build size report label Feb 17, 2022
@github-actions github-actions bot removed the analyze runs build size report label Feb 17, 2022
@pataar pataar requested a review from meteyou February 17, 2022 14:21
@pataar pataar marked this pull request as draft February 17, 2022 18:59
@pataar pataar marked this pull request as ready for review February 17, 2022 20:44
@pataar pataar added the analyze runs build size report label Feb 17, 2022
@github-actions github-actions bot removed the analyze runs build size report label Feb 17, 2022
@meteyou meteyou merged commit fe92b97 into mainsail-crew:develop Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants