Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(lint): upgrade vue ruleset to ‘recommended’ #663

Merged
merged 3 commits into from
Feb 20, 2022
Merged

build(lint): upgrade vue ruleset to ‘recommended’ #663

merged 3 commits into from
Feb 20, 2022

Conversation

pataar
Copy link
Member

@pataar pataar commented Feb 20, 2022

This expands the ruleset currently used for Vue. These fixes have been applied automatically.

I mainly made changes to .eslintrc.json. Had to fix one rule manually in SystemPanel.vue. As key and index were used twice, which might be confusing.

Also some rules have been disabled, as they're hard to fix right now and are not that important.

@pataar pataar marked this pull request as ready for review February 20, 2022 09:16
@pataar pataar added the analyze runs build size report label Feb 20, 2022
@github-actions
Copy link
Contributor

Size Change: -39 B (0%)

Total Size: 1.78 MB

Filename Size Change
./dist/assets/Codemirror.js 113 kB -2 B (0%)
./dist/assets/Heightmap.js 120 kB -2 B (0%)
./dist/assets/index.js 247 kB -33 B (0%)
./dist/assets/Viewer.js 282 kB -3 B (0%)
./dist/sw.js 6.26 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/Codemirror.css 20 B
./dist/assets/Heightmap.css 74 B
./dist/assets/index.css 56.4 kB
./dist/assets/materialdesignicons-webfont.woff2 354 kB
./dist/assets/vendor.js 440 kB
./dist/assets/vendor.css 64.5 kB
./dist/assets/Viewer.css 318 B
./dist/config.json 25 B
./dist/fonts/roboto-black.woff2 11 kB
./dist/fonts/roboto-bold.woff2 11 kB
./dist/fonts/roboto-light.woff2 11.2 kB
./dist/fonts/roboto-medium.woff2 11.1 kB
./dist/fonts/roboto-regular.woff2 11 kB
./dist/fonts/roboto-thin.woff2 11 kB
./dist/img/icons/apple-touch-icon-152x152.png 4.38 kB
./dist/img/icons/favicon-16x16.png 569 B
./dist/img/icons/favicon-32x32.png 1.05 kB
./dist/img/icons/icon-196-png 3.97 kB
./dist/img/icons/icon-512-png 11.1 kB
./dist/img/icons/mstile-150x150.png 4.26 kB
./dist/img/klipper.svg 3.4 kB
./dist/img/logo.svg 4.08 kB
./dist/img/sidebar-background.svg 1.33 kB
./dist/index.html 692 B

compressed-size-action

@meteyou meteyou merged commit 60ce655 into mainsail-crew:develop Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyze runs build size report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants