Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: notifications #738

Merged
merged 56 commits into from
Apr 10, 2022
Merged

feat: notifications #738

merged 56 commits into from
Apr 10, 2022

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Mar 27, 2022 •
edited
Loading

  • display moonraker announcements as a notification
  • snooze & remove announcements notifications
  • add klipper warnings to notifications
  • add moonraker warnings to notifications
  • add raspberry pi flags to notifications

Signed-off-by: Stefan Dej meteyou@gmail.com

meteyou and others added 30 commits March 26, 2022 14:31
@meteyou
feat: add announcements store module + init functions
393c76b 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refactor: add an announcements wrapper in App.vue
8eb8308 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
feat: add announcement snackbar as component
c9da182 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
feat: add dismiss function to announcement
55067da 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refector: move critical announcement filter to getter
573a0d9 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
feat: add announcement menu in topbar
43cbf49 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
feat: add critical announcements to topbar menu
7e50eea 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refector: remove overlay snackbar
0faaf58 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
feat: only display notification button when moonraker component is lo…
47286c8 
…aded

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
fix: remove announcement wrapper
f3499ed 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
feat: add icon to headline
326da7e 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@dw-0
chore: tweak visual appearance (#739)
6172355
@dw-0
chore: more UI/UX tweaks (#740)
e4dd2ee
@meteyou
Merge branch 'develop' into feat/moonraker-announcements
7d18b27
@meteyou
refector: add notification vuex module
d7fef7c 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refector: rename announcementMenu to notificationMenu
96efedf 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refector: rename announcementMenu to notificationMenu
f2bf599 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
feat: add flags to notifications
f1d187a 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
feat: add support for critical notifications
4f4b8e1 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
feat: add support for critical notifications
c7b3479 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refector: add notification type getter
24718a8 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refector: remove old throttled state menu in topbar
7279cbc 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refector: update moonraker min version
7ff779e 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refector: remove old throttled state menu in topbar
03d09c8 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refector: move notifications store in gui module
eb6064e 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
feat: dismiss rpi flags notification with moonraker DB as store
cae7d2b 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
feat: add function to hide flags forever
1fe509b 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
fix: dismiss all "normal" notifications function
029bde2 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refactor: change dismiss logic for flag notifications
3ee2c2f 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refactor: change dismiss all logic for notifications
cb55904 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested a review from dw-0 April 3, 2022 21:17
@meteyou meteyou changed the title feat: moonraker announcements feat: notifications Apr 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022 •
edited
Loading

Size Change: +5.18 kB (0%)

Total Size: 1.51 MB

Filename Size Change
./dist/assets/Codemirror.js 113 kB +1 B (0%)
./dist/assets/Heightmap.js 120 kB -2 B (0%)
./dist/assets/index.css 10.2 kB +57 B (+1%)
./dist/assets/index.js 263 kB +3.67 kB (+1%)
./dist/assets/vendor.js 531 kB +1.45 kB (0%)
./dist/index.html 712 B -1 B (0%)
./dist/sw.js 6.3 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/Codemirror.css 20 B
./dist/assets/Heightmap.css 283 B
./dist/assets/vendor.css 64.5 kB
./dist/assets/Viewer.js 282 kB
./dist/assets/Viewer.css 317 B
./dist/config.json 25 B
./dist/fonts/roboto-black.woff2 11 kB
./dist/fonts/roboto-bold.woff2 11 kB
./dist/fonts/roboto-light.woff2 11.2 kB
./dist/fonts/roboto-medium.woff2 11.1 kB
./dist/fonts/roboto-regular.woff2 11 kB
./dist/fonts/roboto-thin.woff2 11 kB
./dist/img/icons/apple-touch-icon-180x180.png 6.47 kB
./dist/img/icons/favicon-16x16.png 355 B
./dist/img/icons/favicon-32x32.png 641 B
./dist/img/icons/icon-192-png 7.86 kB
./dist/img/icons/icon-512-png 33 kB
./dist/img/icons/mstile-150x150.png 2.24 kB
./dist/img/icons/safari-pinned-tab.svg 1.38 kB
./dist/img/klipper.svg 2.38 kB
./dist/img/logo.svg 295 B
./dist/img/sidebar-background.svg 929 B

compressed-size-action

dw-0
dw-0 requested changes Apr 3, 2022
View reviewed changes
src/store/server/getters.ts Show resolved Hide resolved
@dw-0
Copy link
Member

dw-0 commented Apr 3, 2022

Please also refactor all other locales as much as possible so they match the en locales.

meteyou added 2 commits April 7, 2022 22:20
@meteyou
locale(en): remove unused keys
3aa9f68 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
locale(de): add de locale for notifcations
ba118f0 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested a review from dw-0 April 7, 2022 20:21
meteyou added 10 commits April 7, 2022 23:27
@meteyou
locale(da): add locale for notifications
5b3c5f8 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
locale(es): add locale for notifications
79e425f 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
locale(fr): add locale for notifications
5844a40 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
locale(hu): add locale for notifications
bb82732 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
locale(it): add locale for notifications
476cc69 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
locale(nl): add locale for notifications
0739a71 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
locale(pl): add locale for notifications
4380ca0 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
locale(ru): add locale for notifications
38d8c75 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
locale(zh): add locale for notifications
9d3e2c4 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
locale(zh-tw): add locale for notifications
1fa2c03 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
dw-0
dw-0 requested changes Apr 7, 2022
View reviewed changes
src/locales/de.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
meteyou and others added 4 commits April 7, 2022 23:45
@meteyou @dw-0
locale(en): fix locale
8fa6d57 
Co-authored-by: th33xitus <th33xitus@googlemail.com>
@meteyou @dw-0
locale(de): fix locale
01165d5 
Co-authored-by: th33xitus <th33xitus@googlemail.com>
@meteyou
fix: display issue on mobile devices
f3aa635 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
Merge remote-tracking branch 'origin/feat/moonraker-announcements' in…
2e6aa6f 
…to feat/moonraker-announcements
@meteyou meteyou requested a review from dw-0 April 10, 2022 20:29
dw-0
dw-0 previously approved these changes Apr 10, 2022
View reviewed changes
Copy link
Member

@dw-0 dw-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meteyou
fix: close notification entry expand, when close notification menu
b6bf2d6 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou merged commit d830493 into develop Apr 10, 2022
@meteyou meteyou deleted the feat/moonraker-announcements branch April 10, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dw-0 dw-0 dw-0 approved these changes

@pataar pataar Awaiting requested review from pataar

Assignees
No one assigned
Labels
analyze runs build size report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteyou @dw-0