Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale(ja): add Japanese translation #774

Merged
merged 9 commits into from
May 8, 2022
Merged

locale(ja): add Japanese translation #774

merged 9 commits into from
May 8, 2022

Conversation

chai-md
Copy link
Contributor

@chai-md chai-md commented May 4, 2022

Created Japanese translation

@dw-0
Copy link
Member

dw-0 commented May 7, 2022

Thank you for your contribution. Sadly i am not allowed to push onto this PR and quickly fix it myself to make it merge-ready.
So i ask you to fix the failed checks yourself. Please also run lint:fix on that file, as this will sort the keys according to our eslint rules.

@chai-md
Copy link
Contributor Author

chai-md commented May 7, 2022

Thanks for letting me know, I formatted it with Prettier Extension on Visual Studio Code, but the error did not go away.
I tried overwriting ja.json with the contents of en.json to see how Prettier on github works, but the error did not change.

@dw-0
Copy link
Member

dw-0 commented May 7, 2022

I see, im not quite sure if the issue is, that you committed the file with an indentation level of 2 spaces instead of 4. (we use 4 for locale json files)

Can you now, after you already created the PR allow pushes to your branch from maintainers like me? Then i would try again and run prettier on that file on my machine too and try to fix that somehow.

@chai-md
Copy link
Contributor Author

chai-md commented May 8, 2022

Thank you kindly for your detailed explanation. It seems that my Prettier Extension was not reading the configuration file properly so I fixed the problem in my environment and reformatted it.

This seems to have solved the formatting problem. Thank you very much.

@dw-0
Copy link
Member

dw-0 commented May 8, 2022

Okay now it looks good! We can merge that. Thanks again for your contribution.

@dw-0 dw-0 merged commit c94e70f into mainsail-crew:develop May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants