feat: allow collapsing of config file panel #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes mainsail-crew#937 Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
substr() is deprecated Signed-off-by: Dominik Willner <th33xitus@gmail.com>
meteyou
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #937
some refactoring was also done to fix some weaker IDE warnings.
there is still one warning about a deprecated "slot" symbol:
https://github.com/th33xitus/mainsail/blob/eda51cb85d565f0a05898c8eeea42232fa88cd8b/src/components/panels/Machine/ConfigFilesPanel.vue#L117
i wasn't sure how to approach that though. @meteyou maybe you have an idea? would be nice if we get that fixed before merging as well.
Signed-off-by: Dominik Willner th33xitus@gmail.com