Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: set platform for build target #951

Merged
merged 1 commit into from
Jul 8, 2022
Merged

docker: set platform for build target #951

merged 1 commit into from
Jul 8, 2022

Conversation

mkuf
Copy link
Contributor

@mkuf mkuf commented Jul 8, 2022

This fixes the failed docker Builds caused by #949.

As a bonus, this also speeds up the build process itself.
The nature of the node application allows the generated static files to be used on multiple architectures. Therefore, they only need to be built once and then copied into the platform specific runtime images.

Have a look at the test build I did:

-Markus

@pataar
Copy link
Member

pataar commented Jul 8, 2022

Woah, this is way better than my solution in #950

@pataar pataar merged commit 5f3d80d into mainsail-crew:develop Jul 8, 2022
@pataar
Copy link
Member

pataar commented Jul 8, 2022

Thanks for your contribution Markus, nice solution! I really like https://github.com/mkuf/prind :)

@mkuf
Copy link
Contributor Author

mkuf commented Jul 8, 2022

Thanks, I'm happy you like it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants