work with local testchain snapshot #26

levity · 2019-03-28T23:25:04Z

This is the set of changes I've had to make so far to get the portal working with the local testchain.

starting the local testchain

cd $DAIJS # your dai.js path
git checkout dev
git pull
git submodule update --init --recursive
yarn test:net -s mcd-step-4 --fast

if you also want to make changes to dai.js / dai-plugin-mcd

Here's how you would get things running and auto-refreshing when you make changes to either dai.js or the MCD plugin:

one-time prep:

npm i -g sane yalc

terminal 2:

cd $DAIJS
sane "yarn build:backend && cd dist && yalc publish && cd $PORTAL && yalc link @makerdao/dai" src --wait=3

terminal 3:

cd $DAIJS/lib/dai-plugin-mcd
sane "yalc publish && cd $PORTAL && yalc link @makerdao/dai-plugin-mcd" src --wait=3

terminal 4:

cd $PORTAL # your mcd portal path
yarn start

levity · 2019-03-28T23:29:07Z

Haven't done much testing yet, so there's probably more to do to get it working all the way through. And the issue with price feeds being Median on Kovan and DSValue in the snapshots is a pain; the workaround I put in place is a temporary hack.

levity · 2019-03-28T23:52:38Z

TODO

remove redundant testchain addresses (rely on plugin)
come up with a better way to toggle between Median and DSValue

to avoid confusion between "testnet" and "testchain"

- get rpcUrl, multicallAddress, all other addresses, & the list of ilks from maker instance - remove WatcherProvider since components should not need to interact with the watcher directly - use the MCD plugin's CdpType.getPrice() for price values

vercel · 2019-04-02T23:20:59Z

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://mcd-cdp-portal-git-local-testchain.mkr-js-prod1.now.sh

levity · 2019-04-02T23:45:51Z

OK, this is ready for review!

It is set up by default to handle an environment with Median price feeds. To handle an environment with DSValue price feeds, add simplePriceFeeds=1 to the URL query params.

To test this against a local testchain, please run the commands described in the "terminal 1" section above to start the testchain, and then fire up the MCD portal with ?network=test&simplePriceFeeds=1.

* cdp creation flow: show all ilks regardless of whether we have all addresses * center spaceship illustration even when above a long string * forward all search queries after programatic navigation * don’t redirect at all if MM wallet connection has failed

jparklev · 2019-04-03T09:15:40Z

was able to open a cdp on the local chain using MM with one of these keys imported. made this PR. i think we still need added tokens to accept a string data.address so that we can use addressOverrides for tokens, too. will be back 😴

adrianleb · 2019-04-03T12:14:32Z

My first thought was - why am I looking at npm linking instructions if all I want is to run a testchain instance and this being a PR about local testchain?

These were the steps I took to get things running after reading your comments:

Make sure seth is installed

 git clone @makerdao/dai.js
 cd dai.js && yarn && git submodule update --init --recursive
 yarn test:net -s mcd-step-4 --fast

Add localhost:2000 as a custon network to Metamask
Run mcd-cdp-portal as usual
Navigate to http://localhost:3000?network=test&simplePriceFeeds=1

I'm still not able to develop on mcd-cdp-portal, where can one find a wallet with seeded balances?

Def. think it's useful having instructions on how to run all things all the time, but truth is the 80% use case is just developing the frontend using published versions of said sdk libs. it makes less and less sense having testchain be a dai.js submodule if one is not actively working on the sdk.

That aside, I think this is a great step for the developer experience around this project 🙏.

b-pmcg · 2019-04-03T15:16:22Z

I was able to get it up and running, but I had to make some adjustments to handle added contracts with no network properties.

b-pmcg · 2019-04-03T15:22:44Z

I'm still not able to develop on mcd-cdp-portal, where can one find a wallet with seeded balances?

@adrianleb using the mnemonic that's built into the deploy script outputs "ETH_FROM": "0x16fb96a5fa0427af0c8f7cf1eb4870231c8154b6" to testchain/lib/out/addresses.json. The private key for that (474beb999fed1b3af2ea048f963833c686a0fba05f5724cb6417cf3b8ee9697e) can be found in test/helpers/testAccounts.json and you can send yourself ETH/COL1, etc.

We should probably add this to the testchain setup documentation.

levity · 2019-04-03T17:00:19Z

I'm still not able to develop on mcd-cdp-portal, where can one find a wallet with seeded balances?

@adrianleb using the mnemonic that's built into the deploy script outputs "ETH_FROM": "0x16fb96a5fa0427af0c8f7cf1eb4870231c8154b6" to testchain/lib/out/addresses.json. The private key for that (474beb999fed1b3af2ea048f963833c686a0fba05f5724cb6417cf3b8ee9697e) can be found in `test/helpers/testAccounts.json' and you can send yourself ETH/COL1, etc.

We should probably add this to the testchain setup documentation.

oh yeah, we should just bundle a script that makes it easy to send ETH/COLn from the creator address to the user's metamask account

levity · 2019-04-03T17:01:20Z

My first thought was - why am I looking at npm linking instructions if all I want is to run a testchain instance and this being a PR about local testchain?

@adrianleb my bad, i should have edited that out. as you've noticed, the dai and dai-plugin-mcd deps were updated so you don't need yalc link to use this. edited the original comment for clarity

levity · 2019-04-03T17:15:18Z

it makes less and less sense having testchain be a dai.js submodule if one is not actively working on the sdk.

@adrianleb You can actually do all this with a standalone copy of https://github.com/makerdao/testchain; just substitute scripts/launch for yarn test:net. i just provided instructions based on dai.js because everyone has a copy already.

levity · 2019-04-03T17:19:18Z

@jparklev did you mean to put "QOL tweaks" on develop?

jparklev · 2019-04-03T20:07:31Z

@levity that commit should have been two really, a few of the tweaks I needed to get cdps working for me here, the others could have been committed to develop first. Though they all arose for me in the context of this PR

levity · 2019-04-03T23:23:29Z

I was able to get it up and running, but I had to make some adjustments to handle added contracts with no network properties.

Fixed in the last commit! Lemme know if there's anything else to do here before merging

jparklev · 2019-04-04T05:59:43Z

@levity I think we might hit a little snag with the kovan deployment, where b/c pip refers to the oracle security module, the current getPrice returns a funny value for the gem/usd feed price, which makes the cdp creation flow wonky (fails on formatNumber rn, though that's an easy fix). We could drop a manual getStorageAt back in for now until #101 lands? How does that feel?

Otherwise LGTM :)

levity · 2019-04-04T19:38:37Z

@jparklev ok, i'll review makerdao/dai.js#101, then once that's merged, ship a new point release and then update the deps here

which reads price from the vat

levity · 2019-04-04T19:45:55Z

@jparklev i've got to jump on a call now, so if all looks good, feel free to merge

work with local testchain snapshot

973c61a

levity added 5 commits April 1, 2019 17:31

Merge remote-tracking branch 'origin/develop' into local-testchain

806c003

fall back to mcd plugin if address overrides are not provided

b1eff76

call the test network just "test"

0e6eb8f

to avoid confusion between "testnet" and "testchain"

enable metamask even if we got an account from the provider

1926776

use maker data for watcher

1c058d9

- get rpcUrl, multicallAddress, all other addresses, & the list of ilks from maker instance - remove WatcherProvider since components should not need to interact with the watcher directly - use the MCD plugin's CdpType.getPrice() for price values

vercel bot deployed to staging April 2, 2019 23:20 View deployment

add query param toggle for simplePriceFeeds

c47cbc5

vercel bot deployed to staging April 2, 2019 23:25 View deployment

Merge remote-tracking branch 'origin/develop' into local-testchain

d042526

vercel bot deployed to staging April 2, 2019 23:29 View deployment

update dependencies

d74f561

vercel bot deployed to staging April 2, 2019 23:43 View deployment

levity requested review from jparklev and adrianleb April 2, 2019 23:45

levity changed the title ~~work with local testchain snapshot (WIP)~~ work with local testchain snapshot Apr 2, 2019

QOL tweaks

c350348

* cdp creation flow: show all ilks regardless of whether we have all addresses * center spaceship illustration even when above a long string * forward all search queries after programatic navigation * don’t redirect at all if MM wallet connection has failed

vercel bot deployed to staging April 3, 2019 09:12 View deployment

levity requested a review from michaelelliot April 3, 2019 22:39

bump dai-plugin-mcd dep to fix issue with token address overrides

5bac272

vercel bot deployed to staging April 3, 2019 23:22 View deployment

resolve maker config merge conflict from develop

3c800ec

vercel bot deployed to staging April 4, 2019 04:48 View deployment

Add testchain section to README

db02f73

vercel bot deployed to staging April 4, 2019 05:38 View deployment

upgrade to dai-plugin-mcd v0.1.2

78d7b55

which reads price from the vat

vercel bot deployed to staging April 4, 2019 19:45 View deployment

jparklev merged commit 4d29629 into develop Apr 4, 2019

jparklev deleted the local-testchain branch April 12, 2019 19:06

liamzebedee mentioned this pull request Feb 25, 2020

Maker MCD integration keep-network/tbtc#482

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

work with local testchain snapshot #26

work with local testchain snapshot #26

levity commented Mar 28, 2019 •

edited

Loading

levity commented Mar 28, 2019 •

edited

Loading

levity commented Mar 28, 2019 •

edited

Loading

vercel bot commented Apr 2, 2019

levity commented Apr 2, 2019

jparklev commented Apr 3, 2019 •

edited

Loading

adrianleb commented Apr 3, 2019

b-pmcg commented Apr 3, 2019

b-pmcg commented Apr 3, 2019 •

edited

Loading

levity commented Apr 3, 2019

levity commented Apr 3, 2019 •

edited

Loading

levity commented Apr 3, 2019 •

edited

Loading

levity commented Apr 3, 2019

jparklev commented Apr 3, 2019 •

edited

Loading

levity commented Apr 3, 2019

jparklev commented Apr 4, 2019 •

edited

Loading

levity commented Apr 4, 2019

levity commented Apr 4, 2019

work with local testchain snapshot #26

work with local testchain snapshot #26

Conversation

levity commented Mar 28, 2019 • edited Loading

starting the local testchain

if you also want to make changes to dai.js / dai-plugin-mcd

levity commented Mar 28, 2019 • edited Loading

levity commented Mar 28, 2019 • edited Loading

vercel bot commented Apr 2, 2019

levity commented Apr 2, 2019

jparklev commented Apr 3, 2019 • edited Loading

adrianleb commented Apr 3, 2019

b-pmcg commented Apr 3, 2019

b-pmcg commented Apr 3, 2019 • edited Loading

levity commented Apr 3, 2019

levity commented Apr 3, 2019 • edited Loading

levity commented Apr 3, 2019 • edited Loading

levity commented Apr 3, 2019

jparklev commented Apr 3, 2019 • edited Loading

levity commented Apr 3, 2019

jparklev commented Apr 4, 2019 • edited Loading

levity commented Apr 4, 2019

levity commented Apr 4, 2019

levity commented Mar 28, 2019 •

edited

Loading

levity commented Mar 28, 2019 •

edited

Loading

levity commented Mar 28, 2019 •

edited

Loading

jparklev commented Apr 3, 2019 •

edited

Loading

b-pmcg commented Apr 3, 2019 •

edited

Loading

levity commented Apr 3, 2019 •

edited

Loading

levity commented Apr 3, 2019 •

edited

Loading

jparklev commented Apr 3, 2019 •

edited

Loading

jparklev commented Apr 4, 2019 •

edited

Loading