Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists do not get rendered when bullets = false #234

Closed
regr4 opened this issue May 4, 2021 · 4 comments · Fixed by #235
Closed

Lists do not get rendered when bullets = false #234

regr4 opened this issue May 4, 2021 · 4 comments · Fixed by #235
Labels
bug Something isn't working

Comments

@regr4
Copy link
Contributor

regr4 commented May 4, 2021

Hi, whenever my config.toml contains bullets = false, lists do not show up on screen, but when I have bullets = true, then they do show up. I'm using the latest git commit (a4a56a6..) via Homebrew on MacOS with iTerm2. My config.toml is almost exactly default-config.toml except for some color adjustments, and I've confirmed the problem using the default.

To replicate:

  • set bullets = false in the config
  • visit gemini://gemini.circumlunar.space/
  • there is a missing list after "Gemini is a new internet protocol which:"

I couldn't find another issue about this, my apologies if this is a duplicate.

@regr4
Copy link
Contributor Author

regr4 commented May 4, 2021

I'm pretty sure the problem is in renderer.go at line 227: I don't know much about Go, but if I'm reading it correctly, if bullets is set to false, it just doesn't render the line. I will try to figure out whether this is the case tomorrow.

@singalhimanshu
Copy link
Contributor

I'm pretty sure the problem is in renderer.go at line 227

Yeah you are correct that is where the bug is coming from.
Let me know if you are working on this, else I can submit a PR to fix this.

@regr4 regr4 mentioned this issue May 5, 2021
@regr4
Copy link
Contributor Author

regr4 commented May 5, 2021

I have created a pull request that should fix this issue.

@makew0rld makew0rld added the bug Something isn't working label May 7, 2021
@makew0rld
Copy link
Owner

Ouch, sorry about this. You are correct. Will merge #235 ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants