-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitub actions #84
Open
submarcos
wants to merge
16
commits into
master
Choose a base branch
from
gitub_actions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gitub actions #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
submarcos
commented
Dec 22, 2021
•
edited
Loading
edited
- Move CI to github actions
- Enable defined eslint check in CI
- Fix code to match defined eslint check
fix eslint
Bo-Duke
requested changes
Feb 17, 2022
@@ -30,7 +30,7 @@ <h1>Leaflet Filelayer plugin</h1> | |||
<div>Icons made by <a href="http://www.freepik.com" title="Freepik">Freepik</a> from <a href="http://www.flaticon.com" title="Flaticon">www.flaticon.com</a></div> | |||
</footer> | |||
</body> | |||
<script src="https://unpkg.com/leaflet@1.2.0/dist/leaflet.js"></script> | |||
<script src="https://unpkg.com/leaflet@1.7.1/dist/leaflet.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaflet.css is still in 1.2.0, we should stay on the same version as the .js
I can't comment on the line itself but there it is :
Leaflet.FileLayer/docs/index.html
Line 8 in 06cdb91
<link rel="stylesheet" href="https://unpkg.com/leaflet@1.2.0/dist/leaflet.css"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.