Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitub actions #84

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Gitub actions #84

wants to merge 16 commits into from

Conversation

submarcos
Copy link
Member

@submarcos submarcos commented Dec 22, 2021

  • Move CI to github actions
  • Enable defined eslint check in CI
  • Fix code to match defined eslint check

@submarcos submarcos linked an issue Dec 24, 2021 that may be closed by this pull request
@submarcos submarcos marked this pull request as ready for review February 15, 2022 14:31
@submarcos submarcos requested a review from Bo-Duke February 15, 2022 15:21
@@ -30,7 +30,7 @@ <h1>Leaflet Filelayer plugin</h1>
<div>Icons made by <a href="http://www.freepik.com" title="Freepik">Freepik</a> from <a href="http://www.flaticon.com" title="Flaticon">www.flaticon.com</a></div>
</footer>
</body>
<script src="https://unpkg.com/leaflet@1.2.0/dist/leaflet.js"></script>
<script src="https://unpkg.com/leaflet@1.7.1/dist/leaflet.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaflet.css is still in 1.2.0, we should stay on the same version as the .js

I can't comment on the line itself but there it is :

<link rel="stylesheet" href="https://unpkg.com/leaflet@1.2.0/dist/leaflet.css">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Leaflet 1.7.x
2 participants