Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error validating checksums on node.js 8 #7

Closed
antelle opened this issue Jun 11, 2017 · 2 comments
Closed

Error validating checksums on node.js 8 #7

antelle opened this issue Jun 11, 2017 · 2 comments

Comments

@antelle
Copy link

antelle commented Jun 11, 2017

Hello!

Something got broken after node.js 8 update, please see these bug reports:

electron/electron#8653
electron/electron-api-demos#288
vercel/hyper#1893
electron/electron#9595

Or google for Error: Generated checksum for did not match expected checksum..

I'm too lazy to get a stable reproduction case without other deps, but it can be fixed if you replace 'binary' with null here:
https://github.com/malept/sumchecker/blob/master/index.js#L71

@addaleax
Copy link
Contributor

I think this has been fixed by #5, can you try a latest version of this module?

@antelle
Copy link
Author

antelle commented Jun 11, 2017

Thanks, confirmed, new version of sumchecker doesn't have this issue 👍
Sorry for that, it looks like old versions are still used in some packages (however, it looks like it's backported to v1, but there are also shrinkwrap files of course...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants