From 6557ba4950e1b642529fc89fa4448850d2e34224 Mon Sep 17 00:00:00 2001 From: Jason Smart Date: Tue, 17 Dec 2024 11:41:45 -0800 Subject: [PATCH 1/2] Added test verifying proper behavior for modulus operator. --- test/src/databases/all/expr.spec.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/src/databases/all/expr.spec.ts b/test/src/databases/all/expr.spec.ts index 7c0b44801..583af286e 100644 --- a/test/src/databases/all/expr.spec.ts +++ b/test/src/databases/all/expr.spec.ts @@ -357,6 +357,16 @@ describe.each(runtimes.runtimeList)('%s', (databaseName, runtime) => { } ); + it('uses the correct symbol for modulus, either % or MOD', async () => { + await expect(` + run: aircraft_models->{ + group_by: mod_example is 10 % 4 + } + `).malloyResultMatches(expressionModel, { + mod_example: 2, + }); + }); + it('named query metadata undefined', async () => { const result = await expressionModel .loadQuery( From e01e32a1c224e2fb5476bcfc1898336bca857cd8 Mon Sep 17 00:00:00 2001 From: Jason Smart Date: Tue, 17 Dec 2024 12:09:21 -0800 Subject: [PATCH 2/2] DCO Remediation Commit for Jason Smart I, Jason Smart , hereby add my Signed-off-by to this commit: 6557ba4950e1b642529fc89fa4448850d2e34224 Signed-off-by: Jason Smart