diff --git a/quetz/tests/test_cli.py b/quetz/tests/test_cli.py index 86fc510c..df65ae71 100644 --- a/quetz/tests/test_cli.py +++ b/quetz/tests/test_cli.py @@ -598,16 +598,26 @@ def test_start_server_local_without_deployment( assert res.exit_code == 1 assert "The specified directory is not a deployment" in res.output -# these tests are strange. I assume they use the fact that pytest timeout might send a signal -# this signal is then processed by the Interrupt class, which kills the server ? I don't know -# but life is too short to figure this out, given that the tests are not testing much +# these tests are strange and time out in the CI +# I thing the logic of the test might have been: +# * the test times out +# * this may fires SIGALRM since @pytest.mark.timeout(1) is used +# * this should trigger the installed signal handler +# * this should terminate the thread +# * we finally test if the process (which runs the server) was exited gracefully with a exitcode of 0 +# But long story short, these tests time out in the CI. +# Given their somewhat complicated logic / flow and how little they actually test I would say we just remove them. if False: @pytest.mark.parametrize("sqlite_in_memory", [False]) @pytest.mark.timeout(1) @pytest.mark.xfail(reason="time out") def test_start_server_local_with_deployment_and_config_file( - empty_config_on_exit: None, config, config_dir, create_channels_dir, create_tables + empty_config_on_exit: None, + config, + config_dir, + create_channels_dir, + create_tables, ): """Starting server with deployment directory""" p = Process(target=cli.app, args=(["start", config_dir, "--port", "8001"],))