Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd.exe custom shell doesn't work with micromamba 2 #230

Closed
pavelzw opened this issue Oct 2, 2024 · 11 comments
Closed

cmd.exe custom shell doesn't work with micromamba 2 #230

pavelzw opened this issue Oct 2, 2024 · 11 comments
Labels
bug Something isn't working

Comments

@pavelzw
Copy link
Member

pavelzw commented Oct 2, 2024

image
@pavelzw pavelzw added the bug Something isn't working label Oct 2, 2024
@pavelzw
Copy link
Member Author

pavelzw commented Oct 2, 2024

@jjerphan did something change with micromamba shell init for cmd.exe in micromamba 2?

@pavelzw
Copy link
Member Author

pavelzw commented Oct 2, 2024

looks similar to #227

@jjerphan
Copy link
Member

jjerphan commented Oct 2, 2024

2.0.2 is being released and should fix this issue.

@wolfv
Copy link
Member

wolfv commented Oct 3, 2024

@pavelzw how about we create a new release of this action that's tied to the micromamba version? So that users can depend on setup-microamba@1 and get the 1.x release series (which can be override by manually setting the version) and then we release @2 after some more testing?

@pavelzw
Copy link
Member Author

pavelzw commented Oct 3, 2024

Yes, sounds reasonable :)

I'll create a new release later

@wolfv
Copy link
Member

wolfv commented Oct 3, 2024

Thanks @pavelzw!

@pavelzw
Copy link
Member Author

pavelzw commented Oct 3, 2024

#232

@JohanMabille
Copy link
Member

JohanMabille commented Oct 3, 2024

The thing that changed is that the micromamba.bat script generated by micromamba shell init -s cmd.exe is now called ... mamba.bat. When calling micromamba with v1, it was actually calling micromamba.bat, not the macro micromamba registered by the shell hook. So my feeling is that this was working by accident.

Since the Autorun is explicitely disabled, I think the GHA should copy the mamba.bat script into micromamba.bat to get this working again. The script should not have th same name as the executable because this makes things confusing and leads to a lot of issues when you install / play / debug many versions of micromamba / mamba.

@jjerphan
Copy link
Member

jjerphan commented Oct 7, 2024

@pavelzw: #234 must have resolved this issue. Can you confirm? :)

@pavelzw
Copy link
Member Author

pavelzw commented Oct 7, 2024

yes, ci is green again

@pavelzw pavelzw closed this as completed Oct 7, 2024
@pavelzw
Copy link
Member Author

pavelzw commented Oct 7, 2024

but it introduced #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants