Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update rocksdb verison to fix new macos build issue #764

Open
waynenilsen opened this issue Sep 14, 2020 · 0 comments
Open

Need to update rocksdb verison to fix new macos build issue #764

waynenilsen opened this issue Sep 14, 2020 · 0 comments

Comments

@waynenilsen
Copy link

Problem

I could not build using bin/setup on macos due to a rocksdb build issue.

error: declaration shadows a variable in namespace 'rocksdb'

diem/diem#168
facebook/rocksdb#5303

Solution

Need to get the maintainer of the rocksdb package to pull in the latest code (gitlab) and bump the version on hex. It has not been updated since Feb 9. Alternatively, fork and point to our fork of the rocksdb package. The license is Apache 2.

Testing

With a very new mac, try to run bin/setup it should not work.

> gcc --version
Apple clang version 11.0.3 (clang-1103.0.32.62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant