Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multi-frame packets in ExWire #97

Closed
germsvel opened this issue May 22, 2018 · 1 comment
Closed

Handle multi-frame packets in ExWire #97

germsvel opened this issue May 22, 2018 · 1 comment
Labels
devp2p priority: medium tag: enhancement

Comments

@germsvel
Copy link
Contributor

The RLPx specification says,

A multi-frame packet is a packet which is split (aka chunked) into multiple frames because it's size is larger than the protocol window size

Currently, the Frame module only handles a single or normal frame. At some point we need to handle multi-frame packets.

There is also a TODO comment in lib/ex_wire/framing/frame.ex to that effect.
@germsvel germsvel changed the title Handle multi-frame packets Handle multi-frame packets in ExWire May 22, 2018
This was referenced Sep 6, 2018
Open
Open
@hayesgm
Copy link
Contributor

hayesgm commented Nov 5, 2018

Chunked framing has since been removed from the spec. Do we do cover a single frame being split over multiple packets, however, and this is fixedin #569.

@hayesgm hayesgm closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devp2p priority: medium tag: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hayesgm @germsvel