From f74cdd7154828cb3dd1045390aa72770c2d9b9bb Mon Sep 17 00:00:00 2001 From: Andrew Obuchowicz Date: Tue, 10 Sep 2024 16:10:10 -0400 Subject: [PATCH] fix: temporarily pin goimports in GH Actions to v0.24.0 Part of #1314 The latest version of goimports (v0.25.0) requires go >= 1.22.0. Since we are about to do the upstream release of DWO 0.31.0, we are temporarily pinning goimports to the last working version (v0.24.0). After the 0.31.0 release of DWO, we can safely upgrade the entire repo to go 1.22.0, and use the latest version of goimports again. Signed-off-by: Andrew Obuchowicz --- .github/workflows/code-coverage.yml | 2 +- .github/workflows/pr.yml | 2 +- .github/workflows/release.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/code-coverage.yml b/.github/workflows/code-coverage.yml index 9aef31ba2..e0495c4ab 100644 --- a/.github/workflows/code-coverage.yml +++ b/.github/workflows/code-coverage.yml @@ -40,7 +40,7 @@ jobs: name: Run Go Tests run: | python -m pip install --upgrade pip yq - go install golang.org/x/tools/cmd/goimports@latest + go install golang.org/x/tools/cmd/goimports@v0.24.0 go install github.com/onsi/ginkgo/v2/ginkgo@v2.0.0 make update_devworkspace_crds test - diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 842005b9a..c862471d8 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -73,7 +73,7 @@ jobs: name: Check format run: | go install github.com/google/addlicense@latest - go install golang.org/x/tools/cmd/goimports@latest + go install golang.org/x/tools/cmd/goimports@v0.24.0 if ! make check_fmt; then echo "not well formatted sources are found:" git --no-pager diff diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 2cf9b6c8c..f31e1a6e1 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -121,7 +121,7 @@ jobs: run: | # Need to grab goimports otherwise formatting after this step will fail # PR checks. - go install golang.org/x/tools/cmd/goimports@latest + go install golang.org/x/tools/cmd/goimports@v0.24.0 git config --global user.name "Andrew Obuchowicz" git config --global user.email "aobuchow@redhat.com"