Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installer.flare-vm.vm #1201

Open
Ana06 opened this issue Dec 12, 2024 · 1 comment
Open

Add installer.flare-vm.vm #1201

Ana06 opened this issue Dec 12, 2024 · 1 comment
Assignees
Labels
💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed

Comments

@Ana06
Copy link
Member

Ana06 commented Dec 12, 2024

Details

@mandiant/vms the installer.vm package has been installed >278k times in the last year, as you can see in MyGet. As we are not using this package in the CI or for testing, this means that Commando VM and FLARE-VM have been installed >278k times (together) last year! But sadly we don't have a way to differentiate how many times every of the projects have been installed separately.
image

I propose to add a installer.flare-vm.vm package (and if commando VM wishes also a installer.commando-vm.vm package) that requires the common installer and use the project specific one in the project installers. This will allow us to know the number of individual downloads. @mandiant/vms what do you think? Is there anything that could be moved to the project installer so that they are not only a wrapper but help for example simplify the installation scripts?

For context: FLARE-VM migrated to use the debloat.vm and installer.vm packages shared with Commando VM so that both proects benefit from improvements in mandiant/flare-vm#513. We removed the flarevm.installer.vm package from VM-Packages in #752 and we are going to remove it soon from MyGet (tracked in #907).

@Ana06 Ana06 added 💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed labels Dec 12, 2024
@Ana06 Ana06 self-assigned this Dec 12, 2024
@mr-tz
Copy link
Contributor

mr-tz commented Dec 12, 2024

That's awesome! Congrats to both projects!

I'd would be neat to see the details but I'd only recommend it if it's easy to change and maintain (same for moving functionality - I assume most general packages benefit both projects).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed
Projects
None yet
Development

No branches or pull requests

2 participants