Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node tools fail in CI because of git #1213

Open
Ana06 opened this issue Dec 13, 2024 · 0 comments
Open

Node tools fail in CI because of git #1213

Ana06 opened this issue Dec 13, 2024 · 0 comments
Assignees
Labels
🐛 bug Something isn't working 🏃 CI Related to CI

Comments

@Ana06
Copy link
Member

Ana06 commented Dec 13, 2024

Details

Several Node tools fail to install in our CI. The reason is that the failing tools have a dependency on our nodejs.vm package, that fails to install because nodejs.vm has a dependency of git with no upper bound: and that means it is installing the latest version of git that is in chocolatey, which is 2.47.1. The GitHub runners we use were updated to using this version of git on December 4th: actions/runner-images@d868709. Since then an error occurs when our packages try to install, because it fails to install git since that version is already installed. But I think the tools still get installed because of chocolatey/choco#3487 (it is supposed to be a bug, but it is a feature in this case 🤣).

@emtuls had proposed to ping an older version to fix it in the CI, but this may not fix it for all users that may have another version install.

But I all other fixes I can come up with are much more complicated to implement. As FLARE-VM/Commando-VM are recommended to be installed in an empty VM, unless someone has a better idea, I would go with @emtuls proposal. @mandiant/vms any better ideas?

@Ana06 Ana06 added 🐛 bug Something isn't working 🏃 CI Related to CI labels Dec 13, 2024
@Ana06 Ana06 added this to the FLARE-VM 2025 Q1 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🏃 CI Related to CI
Projects
None yet
Development

No branches or pull requests

2 participants