Passing step via timeInputProps has no effect

[souhagaa]

Dependencies check up

• I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.9.1

What package has an issue?

@mantine/dates

What framework do you use?

create-react-app (CRA)

In which browsers you can reproduce the issue?

All

Describe the bug

When trying to pass step prop via timeInputProps to DateTimePicker but it is not working and if I change it manually in the HTML it works.
It seems like Mantine TimeInput component ignores this prop here

mantine/packages/@mantine/dates/src/components/TimeInput/TimeInput.tsx

Line 124 in 0976f8a

step={withSeconds ? 1 : 60}

a possible solution would be to change that line to step={props.step || withSeconds ? 1 : 60}

If possible, include a link to a codesandbox with a minimal reproduction

https://rb.gy/jmrgpd

Possible fix

No response

Self-service

• I would be willing to implement a fix for this issue

[rtivital]

Fixed in 7.9.2

[tianhuil]

Hi @rtivital: I'm not quite sure how #6204 helps solve the problem. Ideally, we would have

step={props.step || withSeconds ? 1 : 60}

as suggested by @souhagaa . It is not currently done see https://github.com/mantinedev/mantine/blob/master/packages/@mantine/dates/src/components/TimeInput/TimeInput.tsx

I would be happy to implement this and submit a PR

[jannikbuschke]

Also running into this issue