Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO incompatible with regular expression routes #84

Open
jdmswong opened this issue Jan 21, 2016 · 2 comments
Open

SEO incompatible with regular expression routes #84

jdmswong opened this issue Jan 21, 2016 · 2 comments

Comments

@jdmswong
Copy link

Setting a regular expression path throws this error in console:

Exception from Tracker recompute function:
debug.js:41 Error: Cannot currently resolve a regular expression path
    at Url.resolve (url.js:317)
    at Handler.resolve (handler.js:108)
    at Function.Route.path (route.js:163)
    at Function.Route.url (route.js:171)
    at Function.Router.url (router.js:180)
    at Object.SEO.set (manuelschoebel_ms-seo.js:66)
    at Object.SEO.clearAll (manuelschoebel_ms-seo.js:154)
    at Object.SEO.set (manuelschoebel_ms-seo.js:62)
    at manuelschoebel_ms-seo.js:269
    at Tracker.Computation._compute (tracker.js:323)

Here is my route config:

Router.route(/.*/,{
  name: "home",
  template: "myTemplate"
});
@jdmswong
Copy link
Author

removing the route name prevents the error but throws the warning:

You called Router.url for a route named undefined but that route doesn't seem to exist. Are you sure you created it?

This warning is caused by this package, and isn't generated when the package is removed.

So we have to choose between either naming our routes and throwing an error, or not naming them and throwing a warning. Any way to run this cleanly?

@fvpDev
Copy link

fvpDev commented Jul 13, 2016

Any update on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants