Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferred lane direction should be a ManeuverDirection, not a LaneIndication #534

Closed
1ec5 opened this issue Apr 10, 2021 · 2 comments · Fixed by #535
Closed

Preferred lane direction should be a ManeuverDirection, not a LaneIndication #534

1ec5 opened this issue Apr 10, 2021 · 2 comments · Fixed by #535
Assignees
Labels
backwards incompatible changes that break backwards compatibility of public API op-ex Refactoring, Tech Debt or any other operational excellence work.
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Apr 10, 2021

Intersection.validIndication and the preferredDirection associated value of VisualInstruction.Component.lane(indications:isUsable:preferredDirection:) are of type LaneIndication as of #529. But LaneIndication is an option set containing zero or more indications, whereas this property and associated value need to represent one and only one indication. ManeuverDirection has the same cases as LaneIndication but is always a single value. That would allow us to avoid the hack in #529 (comment) #532 (comment) and also allow the navigation SDK to avoid having to convert from LaneIndication to ManeuverDirection in places where it’s already using the primary maneuver direction to influence lane arrow highlighting.

case lane(indications: LaneIndication, isUsable: Bool, preferredDirection: LaneIndication?)

This change would need to take place in v2.0.0 to avoid breaking backwards compatibility.

/cc @mapbox/navigation-ios

@1ec5 1ec5 added backwards incompatible changes that break backwards compatibility of public API op-ex Refactoring, Tech Debt or any other operational excellence work. labels Apr 10, 2021
@1ec5 1ec5 added this to the v2.0.0 (RC) milestone Apr 10, 2021
@zugaldia
Copy link
Member

This change would need to take place in v2.0.0 to avoid breaking backwards compatibility.

Let's prioritize this work to make sure we don't miss the window.

/cc: @truburt

@jill-cardamon
Copy link
Contributor

PR for this ticket: #535
Double checking tests with Directions API response now.

@1ec5 1ec5 linked a pull request Apr 12, 2021 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards incompatible changes that break backwards compatibility of public API op-ex Refactoring, Tech Debt or any other operational excellence work.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants