Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "circle-opacity" style property #1323

Closed
lucaswoj opened this issue Jun 24, 2015 · 6 comments
Closed

Add a "circle-opacity" style property #1323

lucaswoj opened this issue Jun 24, 2015 · 6 comments
Assignees
Milestone

Comments

@lucaswoj
Copy link
Contributor

Related to mapbox/mapbox-gl-style-spec#304

@lucaswoj lucaswoj self-assigned this Jun 24, 2015
@jfirebaugh jfirebaugh added this to the 0.9 milestone Jun 25, 2015
@ansis
Copy link
Contributor

ansis commented Jul 8, 2015

implemented in #1364 and #1347

@ansis ansis closed this as completed Jul 8, 2015
@lucaswoj
Copy link
Contributor Author

lucaswoj commented Aug 6, 2015

These changes were reverted from v8 along with the rest of data-driven styling.

@lucaswoj lucaswoj reopened this Aug 6, 2015
@lucaswoj
Copy link
Contributor Author

lucaswoj commented Aug 6, 2015

Little did he know that the changes were not actually reverted https://github.com/mapbox/mapbox-gl-js/blob/v8/js/style/style_layer.js#L184

@lucaswoj lucaswoj closed this as completed Aug 6, 2015
@jfirebaugh
Copy link
Contributor

So something like f6b6151 is not necessary?

@jfirebaugh
Copy link
Contributor

Yeah, that looks wrong, it's reading a layout property. Deleting the branch.

@lucaswoj
Copy link
Contributor Author

The opacity is applied for all layer types here https://github.com/mapbox/mapbox-gl-js/blob/v8/js/style/style_layer.js#L189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants