Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error handling in style consistent #3879

Open
jfirebaugh opened this issue Jan 2, 2017 · 0 comments
Open

Make error handling in style consistent #3879

jfirebaugh opened this issue Jan 2, 2017 · 0 comments
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API

Comments

@jfirebaugh
Copy link
Contributor

Erroneous uses of the runtime styling API in some cases propagate errors by throwing (e.g. here, here, here, here) and in other cases by emitting an error event (e.g. here, here, here).

We have previously agreed that all errors should be propagated via the error event, so should convert the cases that throw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API
Projects
None yet
Development

No branches or pull requests

1 participant