-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop prefixes in property names #4083
Comments
From @jfirebaugh on November 20, 2014 1:31 Given that we need the prefix for symbol properties, and we might want to use them for a combination stroked and filled "polygon" type layer as well, I think we should keep them universal. |
From @jfirebaugh on January 30, 2015 19:44 Keeping these for now. |
From @1ec5 on December 21, 2016 22:59 Dropping the redundant prefixes would be highly desirable for the iOS and macOS SDKs, where property names are expected to be grammatical: mapbox/mapbox-gl-native#6577 (comment). As of mapbox/mapbox-gl-native#7457, we have to twist the English language in weird ways to ensure that Boolean property names in particular use the right parts of speech. |
More motivation for dropping prefixes on iOS and macOS: https://swift.org/documentation/api-design-guidelines/#omit-needless-words In mapbox/mapbox-gl-native#6577 (comment), we discussed dropping them just from the iOS/macOS runtime styling API, which wouldn’t have required any changes to the style specification, but there was no consensus. Doing so now would require a major version bump for the iOS SDK. |
Closing here; see #6584. |
From @peterqliu on November 17, 2014 21:9
Namely,
fill-
,line-
,raster-
,background-
These prefixes automatically take after the layer's
type
, and as long as they live on separate layers, are redundant. The other prefixesicon-
andtext-
are necessary, since they can cohabit the samesymbol
layer.Copied from original issue: mapbox/mapbox-gl-style-spec#218
The text was updated successfully, but these errors were encountered: