Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "text-halo" to "text-stroke" #4161

Closed
lucaswoj opened this issue Feb 1, 2017 · 3 comments
Closed

Rename "text-halo" to "text-stroke" #4161

lucaswoj opened this issue Feb 1, 2017 · 3 comments
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)

Comments

@lucaswoj
Copy link
Contributor

lucaswoj commented Feb 1, 2017

From @lucaswoj on December 23, 2016 14:36

See the discussion here: mapbox/mapbox-gl-style-spec#379

Copied from original issue: mapbox/mapbox-gl-style-spec#636

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @ajashton on January 2, 2017 19:16

The functionality of the current text-halo is much closer to CSS's text-shadow than text-stroke. The halo is only ever outset from the symbol, whereas a stroke is centered directly on the outline of the symbol. The halo can be blurred while strokes cannot. Strokes can have various dasharrays, round/bevel/miter joins, and offsets but halos cannot.

Going with 'stroke' for the circle symbol as discussed in #379 seems reasonable, but I think the situation for text is quite different and it might not be worth conflating the two, unless the plan is to bring halo and stroke features more in line with each other?

@lucaswoj lucaswoj added the breaking change ⚠️ Requires a backwards-incompatible change to the API label Feb 1, 2017
@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @nickidlugash on January 3, 2017 1:42

Agree with @ajashton on all the above points.

The functionality of the current text-halo is much closer to CSS's text-shadow than text-stroke.

And using a Photoshop analogy, the current text-halo is much closer to the outer-glow blend mode than the stroke blend mode.

@1ec5 1ec5 added the cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) label Feb 3, 2017
@jfirebaugh
Copy link
Contributor

Closing here; see #6584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
Projects
None yet
Development

No branches or pull requests

3 participants