Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] "camera to tile distance" collision approximation breaks down for overzoomed tiles #5095

Closed
ChrisLoer opened this issue Aug 3, 2017 · 1 comment
Assignees

Comments

@ChrisLoer
Copy link
Contributor

We approximate the shape of collision boxes based on the distance from the camera to the center of the tile. On highly overzoomed, pitched maps, the center of the tile can be far outside of the viewport, so the approximation can be wildly off:

screenshot 2017-08-03 16 41 23

The effect will tend to create lots of extra collisions (unnecessarily hidden labels), and also make collision detection more expensive.

This will be fixed incidentally by the global collision detection changes.

/cc @ansis @mollymerp @asheemmamoowala

@ChrisLoer ChrisLoer self-assigned this Aug 4, 2017
@ChrisLoer ChrisLoer changed the title "camera to tile distance" collision approximation breaks down for overzoomed tiles [bug] "camera to tile distance" collision approximation breaks down for overzoomed tiles Oct 17, 2017
@ChrisLoer
Copy link
Contributor Author

Fixed in #5150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants