Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circles duplicated on zoom between zoom level cutoffs #5829

Closed
pjsier opened this issue Dec 8, 2017 · 5 comments
Closed

Circles duplicated on zoom between zoom level cutoffs #5829

pjsier opened this issue Dec 8, 2017 · 5 comments

Comments

@pjsier
Copy link

pjsier commented Dec 8, 2017

mapbox-gl-js version: 0.42.1 (but also seen in 0.42.2)

Steps to Trigger Behavior

  1. Create a circle layer with an opacity less than 1, or that changes size on zoom
  2. Zoom into the layer, and around breakpoints between zoom levels the circles are duplicated

Expected Behavior

Circles should change gradually if there is a zoom function or expression applied

Actual Behavior

Circles look like they're being duplicated between layers, but the duplicate is removed after zooming a bit further. Here are two examples:

From a data-driven styling demo on 0.42.1 where you can see the opacity change where it looks like the circles are duplicated:
circle-zoom

An example where the duplication is more clear with size and opacity change is more clear, on 0.42.2:
duplicate-circles

Whenever this appears, this error is logged in the console:

columnNumber: 765
fileName: "https://api.tiles.mapbox.com/mapbox-gl-js/v0.42.1/mapbox-gl.js"
lineNumber: 490
message: "Error"
stack: "[243]</Actor.prototype.receive@https://api.tiles.mapbox.com/mapbox-gl-js/v0.42.1/mapbox-gl.js:490:765\n"
@jfirebaugh
Copy link
Contributor

Duplicate of #4691. In this case, it looks like the response code is 404 instead of 200, but the result is the same.

@pjsier
Copy link
Author

pjsier commented Dec 8, 2017

@jfirebaugh thanks for the quick reply, and sorry for missing that. In that issue a 200 code with empty content raises an exception, but based on #1800 shouldn't a 404 be handled the same way as a 204?

@jfirebaugh
Copy link
Contributor

A 200 with empty content and a 404 both trigger loading parent tiles, which is what causes overdrawing.

@pjsier
Copy link
Author

pjsier commented Dec 8, 2017

Great, thanks for the clarification!

@jfirebaugh
Copy link
Contributor

#6768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants