Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raster broken by OffscreenCanvas on chrome on MacMini #9100

Closed
astojilj opened this issue Dec 12, 2019 · 2 comments · Fixed by #9103
Closed

raster broken by OffscreenCanvas on chrome on MacMini #9100

astojilj opened this issue Dec 12, 2019 · 2 comments · Fixed by #9103
Assignees
Labels

Comments

@astojilj
Copy link
Contributor

astojilj commented Dec 12, 2019

After 85517f0, debug/satellite.html shows black tiles on macos 10.15.1 on Chrome. No error in console.

Works fine on Firefox and Safari on the same hardware. Render tests pass.

Mac Mini 2018 3.2 GHz 6-Core Intel Core i7 (Intel UHD Graphics 630 1536 MB)
Chrome Version 78.0.3904.108 (Official Build) (64-bit)

Expected (works fine when offscreenCanvasSupported() returns false):
Screen Shot 2019-12-12 at 20 05 02

Actual:

Screen Shot 2019-12-12 at 20 04 09

cc @arindam1993 @kkaefer

@astojilj
Copy link
Contributor Author

Edit:
There is no issue noticeable in hillshade.html. RGBA images are all black in debug/image.html, debug/multiple.html...

Works fine when offscreenCanvasSupported() returns false.

@arindam1993
Copy link
Contributor

Can confirm this is happening on any browser that supports OffscreenCanvas+ImageBitmap, was a result of a major derp wherein the ImageBitmap type check wasn't added in Texture.
This worked fine for everything else (icons, glyphs, hillshade) because we transform those textures into our internal RGBAImage or AlphaImage types.

Fix is out in #9103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants