-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.9.0 add "fill-extrusion-pattern" webgl is not working properly #9479
Comments
@karimnaaji might be related to the change in #9372? |
I checked the sanity of #9372 to see if it introduced a regression. There are no regression introduced by this specific PR, though, while looking at that I found another bug, which is in the vertex layout of pattern attributes. Explicitly setting this offset to 0 assumes that all vertices within this layout start at the same byte in the vertex format. This is incorrect since this layout has 4 different components, each of which starts at byte offsets 0, 8, 16 and 17. This may have been silently broken for some time and adding new attributes in this layout did not take effect for DDS. For this particular issue, @nuancheng , you need to use Using addImage with |
We are talking about the same problem and I understand what you are trying to show, I tried to give you details so you can follow us there. The path forward would be taken from #9482. Can you give more information on these new screenshots? The code is truncated and I'm wondering whether you used the same as the initial examples as I can't repro the first screenshot; it makes it hard to make any assumption about how it's being used. Here is your code snippet with the fix: https://jsbin.com/dagixugazi/edit?html,output |
Possibly related as suggested in #9394 , previously zooming would keep scaling of fill-patterns relatively constant, now it gives visually distorted/broken behaviour, see an example of zooming below with: |
https://jsbin.com/dagixugazi/edit?html,output In addition, I want to ask you a question. Now after the building is pasted with texture, the magnified texture of the field of vision will be recalculated. Is there any way to prohibit recalculation? The texture effect varies greatly under different zoom, which makes people feel a little strange. |
@Plantain Thanks for the details, using @nuancheng I think we will need a better example, using the full atlas of icons was ok to exemplify the issue you initially opened but does not give an appropriate representation for what you are suggesting. Can you open another issue applying a texture that would seamlessly repeat to better express this? |
The latest version adds 3D architectural texture, and the webgl is not working properly
V1.8.0 is normal
mapbox-gl-js version: v1.9.0
browser: Google Chrome 80.0.3987.149
Steps to Trigger Behavior
Link to Demonstration
"fill-extrusion-pattern": { property: "height", type: "interval", stops: [[40, "catcat"]] },
wrong:https://jsbin.com/yazutumoxa/edit?html,output
Expectant:https://jsbin.com/yazutumoxa/3/edit?html,output
Expected Behavior
Actual Behavior
The text was updated successfully, but these errors were encountered: