Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Never resolve tokens after evaluating a text-field or icon-image expression #10399

Closed
anandthakker opened this issue Nov 7, 2017 · 2 comments
Assignees
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS

Comments

@anandthakker
Copy link
Contributor

GL Native quivalent of mapbox/mapbox-gl-js#5599

@anandthakker anandthakker added Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS labels Nov 7, 2017
@anandthakker
Copy link
Contributor Author

I think this will be much cleaner to implement once basic SDK support is in place, because at that point, we can likely remove the {Camera,Source,Composite}Function<T> templates (or at least their corresponding *Stops<T> members), making the function => expression conversion code much more tightly contained.

Since resolving this issue amounts to adding token string => ["concat", ...] to that conversion, it will be a simpler and cleaner change at that point than it would be now.

@1ec5
Copy link
Contributor

1ec5 commented Apr 11, 2018

Fixed in #11509.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

No branches or pull requests

3 participants