Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove remaining style classes references #11495

Open
asheemmamoowala opened this issue Mar 21, 2018 · 7 comments
Open

Remove remaining style classes references #11495

asheemmamoowala opened this issue Mar 21, 2018 · 7 comments
Labels
archived Archived because of inactivity good first issue Good for newcomers Node.js node-mapbox-gl-native

Comments

@asheemmamoowala
Copy link
Contributor

Carried forward from #11477(comment).

Documentation for style classes still exists in the node bindings in the Readme.

Cod for parsing style classes also lingers in:

if (Nan::Has(obj, Nan::New("classes").ToLocalChecked()).FromJust()) {
auto classes = Nan::To<v8::Object>(Nan::Get(obj, Nan::New("classes").ToLocalChecked()).ToLocalChecked()).ToLocalChecked().As<v8::Array>();
const int length = classes->Length();
options.classes.reserve(length);
for (int i = 0; i < length; i++) {
options.classes.emplace_back(std::string { *Nan::Utf8String(Nan::To<v8::String>(Nan::Get(classes, i).ToLocalChecked()).ToLocalChecked()) });
}
}

Both of these references should be removed. Style classes were removed from the rest of the code base in #8953.

@stale
Copy link

stale bot commented Oct 25, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the archived Archived because of inactivity label Oct 25, 2018
@asheemmamoowala
Copy link
Contributor Author

This is still valuable code & doc cleanup that should be done

@stale stale bot removed the archived Archived because of inactivity label Oct 26, 2018
@stale stale bot added the archived Archived because of inactivity label Apr 24, 2019
@stale
Copy link

stale bot commented Apr 24, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Apr 24, 2019
@stale stale bot removed the archived Archived because of inactivity label Apr 25, 2019
@stale stale bot added the archived Archived because of inactivity label Oct 22, 2019
@stale
Copy link

stale bot commented Oct 22, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Oct 22, 2019
@stale stale bot removed the archived Archived because of inactivity label Oct 22, 2019
@stale stale bot added the archived Archived because of inactivity label Apr 19, 2020
@stale
Copy link

stale bot commented Apr 19, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Apr 19, 2020
@alexshalamov alexshalamov reopened this Apr 20, 2020
@stale stale bot removed the archived Archived because of inactivity label Apr 20, 2020
@alexshalamov
Copy link
Contributor

/cc @springmeyer

@stale stale bot added the archived Archived because of inactivity label Oct 17, 2020
@1rayanharoon
Copy link

Hey, I am a beginner at open source. Can you please tell/guide me on what contribution I could make here?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity good first issue Good for newcomers Node.js node-mapbox-gl-native
Projects
None yet
Development

No branches or pull requests

3 participants