Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Integration test: query-test #12044

Closed
tobrun opened this issue Jun 1, 2018 · 2 comments
Closed

Integration test: query-test #12044

tobrun opened this issue Jun 1, 2018 · 2 comments
Assignees
Labels
Android Mapbox Maps SDK for Android archived Archived because of inactivity tests

Comments

@tobrun
Copy link
Member

tobrun commented Jun 1, 2018

In the test/integration/query-test, we define query tests to verify correctness and consistency between mapbox-gl-js and mapbox-gl-native. With render tests now executing on Android in #12041 we can add the same integration for query tests.

Example query test:

{
  "version": 8,
  "metadata": {
    "test": {
      "height": 256,
      "queryGeometry": [
        10,
        100
      ]
    }
  },
  "center": [
    13.418056,
    52.499167
  ],
  "zoom": 14,
  "sources": {
    "mapbox": {
      "type": "vector",
      "maxzoom": 14,
      "tiles": [
        "local://tiles/{z}-{x}-{y}.mvt"
      ]
    }
  },
  "layers": [
    {
      "id": "road",
      "type": "circle",
      "source": "mapbox",
      "source-layer": "road",
      "paint": {
        "circle-radius": 10
      },
      "interactive": true
    }
  ]
}

MapSnapshotter#queryRenderedFeatures

To support this kind of test we need to Integrate query render features on MapSnapshotter. Flagging that this can also be useful for end-users (eg. if they want to dynamically define Marker placement based on the results from a query). To integrate the tes itselft, we need to read out the queryGeometry from the test json and feed that to the MapSnapshotter.

cc @LukasPaczos @ChrisLoer

@tobrun tobrun added Android Mapbox Maps SDK for Android tests labels Jun 1, 2018
@stale stale bot added the archived Archived because of inactivity label Dec 12, 2018
@stale
Copy link

stale bot commented Dec 12, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Dec 12, 2018
@tobrun tobrun reopened this Dec 12, 2018
@stale stale bot removed the archived Archived because of inactivity label Dec 12, 2018
@stale stale bot added the archived Archived because of inactivity label Jun 10, 2019
@stale
Copy link

stale bot commented Jun 10, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android archived Archived because of inactivity tests
Projects
None yet
Development

No branches or pull requests

2 participants