Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Consolidate abstract components files under modules folder #13432

Closed
zugaldia opened this issue Nov 21, 2018 · 4 comments
Closed

[android] Consolidate abstract components files under modules folder #13432

zugaldia opened this issue Nov 21, 2018 · 4 comments
Labels
Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules

Comments

@zugaldia
Copy link
Member

As part of the work to introduce abstract components #12468 we moved some new files to the modules packages but, in order to adhere to SEMVER, some files couldn't be moved (see, for example, #12468 (comment)).

As we work on the next release, which will be bringing SEMVER major changes, we should finalize that work and have all files for all components under modules. This list includes the new logger (i.e. /log/*), http client (/http/*), and telemetry (already fully moved?). @mapbox/maps-android: anything else we should move to modules this time around?

@zugaldia zugaldia added Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules labels Nov 21, 2018
@tobrun
Copy link
Member

tobrun commented Nov 22, 2018

@zugaldia thank you for ticketing this out, been looking into this and these are my findings so far:

* = logging is not part of the Module Provider and it's not required for users to exclude any file for creating another log config.

With follow issues ticketed and no concrete follow up needed here I'm not seeing a need to keep this ticket open. Closing, fee free to reopen if there is a need for it.

@tobrun tobrun closed this as completed Nov 22, 2018
@zugaldia
Copy link
Member Author

Thanks @tobrun for the quick eyes and for digging up those additional issues.

Don't we still need to move all http/* files to modules/http?

@tobrun
Copy link
Member

tobrun commented Nov 26, 2018

The files in http are either the definition or the hook for the sdk. These are required for all builds, they are also used if you would choose to swap out okhttp for another http client.

@zugaldia
Copy link
Member Author

Thank you @tobrun for clarifying - additionally, the leftover work that sparked this ticket #12468 (comment) was done as part of #13244.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Projects
None yet
Development

No branches or pull requests

2 participants