You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
In the process of creating tests for #13727, if you set the annotation scale to 0.25 here: 5d5c7c2#diff-5ad7f1abd760365da09957a2738c498bR44, then the tests fail (the expected position of the callout, not whether the map was panned).
This needs investigating: I believe this is down to the expected behaviour clashing with how the callout decides to position itself:
In the process of creating tests for #13727, if you set the annotation scale to 0.25 here: 5d5c7c2#diff-5ad7f1abd760365da09957a2738c498bR44, then the tests fail (the expected position of the callout, not whether the map was panned).
This needs investigating: I believe this is down to the expected behaviour clashing with how the callout decides to position itself:
https://github.com/mapbox/mapbox-gl-native/blob/5d5c7c29f3587beb8f8f522030a47d6145cabe25/platform/ios/vendor/SMCalloutView/SMCalloutView.m#L369-L398
which could also (potentially) clash with the
marginInsetsHintForPresentationFromRect:
method:https://github.com/mapbox/mapbox-gl-native/blob/5d5c7c29f3587beb8f8f522030a47d6145cabe25/platform/ios/vendor/SMCalloutView/SMCalloutView.m#L270-L298
since there is similar behaviour here.
Given that this is believed to be an edge-case, and that we'd like to drop
SMCalloutView
(#4392) - I'd consider this issue low priority.Configuration
Mapbox SDK versions: 4.8.0-alpha.1 @ 5d5c7c29f3587beb8f8f522030a47d6145cabe25
The text was updated successfully, but these errors were encountered: