Layer Index Is Ignored

[bwuso]

Adding a layer using the Style.addLayerAbove, Style.addLayerBelow, Style.addLayerAt does not affect the map layer order.

This happened after upgrading the SDK from 5.4.1 to 7.4.0-Alpha (needed fix for disabling binaries).

This only happens on 7.4.0-Alpha builds

Steps to reproduce

1. Instantiate Mapbox and have style load with a base "custom-satellite" layer.
2. Add Layer 1's source to the style via style.addSource.
3. Add Layer 1 to the style via style.addLayerAfter(layer1, "custom-satellite").
4. Add Layer 2's source to the style via style.addSource.
5. Add Layer 2 to the style via style.addLayerBefore(layer2, layer1.getId());.

Expected behavior

Layer 2(the b/w satellite imagery) should be beneath Layer 1 (orange boundary line).

Actual behavior

Layer 2(the b/w satellite imagery) is on top of Layer 1 (orange boundary line).

Configuration

Android versions: 7.1.2
Device models: Google Pixel
Mapbox SDK versions: 7.4.0-alpha.1

Workaround

1. Call addLayer on Layer 2 before adding Layer 1.

or

1. Remove Layer 1
2. Remove Layer 1's Source (important)
3. Add Layer 1's Source (important)
4. Add Layer 1

Debugging

While debugging this during the add step. A call to nativeMap.getLayers() revealed that it was adding the layers at least in the right index. Here is the ordered list of getId() on the layers.

1. satellite
2. satellite_carousel_image - (Layer 2)
3. orange_boundary_id - (Layer 1)
4. com.mapbox.annotations.point
5. mapbox-android-symbol-layer
6. mapbox-location-shadow-layer
7. mapbox-location-accuracy-layer
8. mapbox-location-background-layer
9. mapbox-location-foreground-layer
10. mapbox-location-bearing-layer

Other Possible Related Issues

I suspect that this is also connected to other issues in our app with LocationComponent's user location marker and any markers made with SymbolManager's .create.

Image showing location component's marker underneath the drawn boundary layers.

Image showing the marker is covered by the layers even though the layers are under the symbol and annotations layers.

[bwuso]

Fixed by #14408