Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] presentsWithTransaction logic should include callout views. #14442

Closed
julianrex opened this issue Apr 16, 2019 · 0 comments · Fixed by #14445
Closed

[ios] presentsWithTransaction logic should include callout views. #14442

julianrex opened this issue Apr 16, 2019 · 0 comments · Fixed by #14445
Labels
iOS Mapbox Maps SDK for iOS

Comments

@julianrex
Copy link
Contributor

PR #14307 introduced logic that enables presentsWithTransaction if there are any view annotations.

However, we can also have UIView callouts with sprite annotations, so we should also check for a callout.

Here's a gif from an iPhone 6+ running https://github.com/mapbox/ios-sdk-examples/tree/7e2594780ee806ac3b3aa67b94b07aae3d773994

callout-jitter-iphone6+

This is the same behavior as the user location annotation, though subjectively looks worse with the larger callouts.

Mapbox SDK versions: 4.10.0-beta.3
iOS/macOS versions: 12.2
Device/simulator models: 12.3 beta 1 (16F5117h)
Xcode version: 10.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS
Projects
None yet
1 participant