Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Check to see if responding to UIDeviceOrientationDidChangeNotification is required. #14661

Closed
julianrex opened this issue May 14, 2019 · 2 comments
Closed

[ios] Check to see if responding to UIDeviceOrientationDidChangeNotification is required. #14661

julianrex opened this issue May 14, 2019 · 2 comments
Labels
bug iOS Mapbox Maps SDK for iOS
Milestone
ios-future

Comments

@julianrex
Copy link
Contributor

julianrex commented May 14, 2019 •
edited
Loading

Recent testing has hinted at the fact that we may not need the deviceOrientationDidChange: method - it looks like this can trigger multiple calls to layoutSubviews. This needs to be thoroughly investigated.

Marking as a bug, pending clarification.
@julianrex julianrex added bug iOS Mapbox Maps SDK for iOS labels May 14, 2019
@julianrex julianrex changed the title [ios] Check to see if responding to UIDeviceOrientationDidChangeNotification is required. [ios] Check to see if responding to UIDeviceOrientationDidChangeNotification is required. May 14, 2019
@julianrex julianrex mentioned this issue May 14, 2019
Merged
@julianrex julianrex added this to the ios-future milestone May 14, 2019
@1ec5
Copy link
Contributor

1ec5 commented May 18, 2019

We may still need it in order to ensure that the center coordinate remains at the center.

@julianrex
Copy link
Contributor Author

Closing as stale.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
ios-future
Development

No branches or pull requests
2 participants
@1ec5 @julianrex