Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Allow more annotation callout view customization #2211

Closed
friedbunny opened this issue Aug 31, 2015 · 16 comments
Closed

Allow more annotation callout view customization #2211

friedbunny opened this issue Aug 31, 2015 · 16 comments
Labels
feature GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS
Milestone

Comments

@friedbunny
Copy link
Contributor

Our annotation callout view is currently hardcoded to a plain SMCalloutView and only offers custom title/subtitle text and customization of the left and right accessory views.

We should expose our SMCalloutView object and/or provide a delegate method for setting a custom callout view on a per annotation basis.

/cc @1ec5 @incanus

@friedbunny friedbunny added feature iOS Mapbox Maps SDK for iOS labels Aug 31, 2015
@wrutkowski
Copy link

Possible duplicate of #1784

@friedbunny
Copy link
Contributor Author

Possible duplicate of #1784

#1784 is a similar use case, but refers to adding arbitrary custom native views as annotations on top of the GL map view. This ticket refers to our existing callout view, which needs to be better exposed for customization.

@Name-less
Copy link

Someone know if callout view customization will be avaible ?

@robipresotto
Copy link

+1

@ljbade ljbade added the GL JS parity For feature parity with Mapbox GL JS label Oct 25, 2015
@ljbade
Copy link
Contributor

ljbade commented Oct 25, 2015

@friedbunny Adding parity ticket as we already have this feature in Android release.

@RomainQuidet
Copy link
Contributor

Hi, we need this feature at Mappy, I'm working on adding an API to set a custom callout view

@RomainQuidet
Copy link
Contributor

new pull request done: #3322

@bloemy7
Copy link

bloemy7 commented Dec 18, 2015

Hi,

is this possible with the new pull request? I'd like to display a UIView instead of the default callout, is this achievable?

Thanks!

@byroncoetsee
Copy link

That's what I'm busy doing at the moment @YBthebest . You can do it by returning false for the annotationCanShowCallout delegate method and handling the annotation manually. For example show your custom UIView from that method with the information contained in the annotation (which already comes in as an argument in the annotationCanShowCallout method)

@RomainQuidet
Copy link
Contributor

@byroncoetsee it's already done by this pull request #3322
@YBthebest Yes just pull the branch dedicated to #3322 and go to the demo app, there is an example.

@bloemy7
Copy link

bloemy7 commented Dec 18, 2015

@RomainQuidet sorry I'm fairly new to Github and its process, how can I pull your branch? I can't seem to find an URL

@RomainQuidet
Copy link
Contributor

if you're new to github use the graphical app from github or bitbucket (I like sourceTree on MacOSX). From the graphical app, you have a remote source where you'll see all branches, find the one starting with 2211_ it's the one I worked on. then double click on it to pull it from the source.
If you're new to Git, read some doc about sources management!

@bloemy7
Copy link

bloemy7 commented Dec 18, 2015

Thanks for the tips, I have started reading all the docs !

For the time being, I am using SourceTree, and it's quite weird because in the "Remotes" => "origin" section, I see loads of branches, but the 2211 branch isn't there...

@RomainQuidet
Copy link
Contributor

@YBthebest Sorry, it's not in MapBox repo yet, it's in our fork : https://github.com/Mappy/mapbox-gl-native

@bloemy7
Copy link

bloemy7 commented Dec 22, 2015

Will it be in the MapBox repo soon? Thanks for the great work

@friedbunny
Copy link
Contributor Author

Fixed by #3456.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

8 participants