You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
parseFeatures: determines the text we need to display by replacing tokens and applying text transformations, and the glyphs we need
addFeatures: determines the potential position of labels
placeFeatures: actually places them and adds them to a buffer
placeFeatures is currently called as the last step in addFeatures, but there's no good reason to; we could separate that out and call the addFeatures without placing as soon as we have the symbols. Then we would have less work to do later. However, it means we'd have to introduce a third step beyond pending.
The text was updated successfully, but these errors were encountered:
jfirebaugh
changed the title
Separate SymbolBucket::addFeatures and SymbolBucket::placeFeatures
Rename SymbolBucket::addFeatures and SymbolBucket::placeFeatures
Sep 9, 2016
From #2873 (comment):
There are actually three steps:
parseFeatures
: determines the text we need to display by replacing tokens and applying text transformations, and the glyphs we needaddFeatures
: determines the potential position of labelsplaceFeatures
: actually places them and adds them to a bufferplaceFeatures
is currently called as the last step inaddFeatures
, but there's no good reason to; we could separate that out and call theaddFeatures
without placing as soon as we have the symbols. Then we would have less work to do later. However, it means we'd have to introduce a third step beyondpending
.The text was updated successfully, but these errors were encountered: