Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Elongated, black triangles on random streets #5234

Closed
1ec5 opened this issue Jun 3, 2016 · 5 comments
Closed

Elongated, black triangles on random streets #5234

1ec5 opened this issue Jun 3, 2016 · 5 comments
Labels
bug Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jun 3, 2016

As of 7a43f8b on master, I’m seeing some occasional artifacting in the form of elongated, black triangles at either endpoint of a street. For example, here’s a screenshot of the 12/1171/1566 tile in Mapbox Streets v9 on iOS 9.3 on an iPhone 6 after choosing Add 100 Point Annotations from the menu:

12/1171/1566

Here are some more examples in the 11/585/783 tile:

12/1171/1566

/cc @jfirebaugh @kkaefer

@1ec5 1ec5 added bug Core The cross-platform C++ core, aka mbgl labels Jun 3, 2016
@jfirebaugh
Copy link
Contributor

Can you bisect this?

@1ec5
Copy link
Contributor Author

1ec5 commented Jun 4, 2016

A bisect implicates a43940a, part of #4839. 27baa34 is unaffected by this bug.

@1ec5
Copy link
Contributor Author

1ec5 commented Jun 4, 2016

Also worth noting that this issue affects iPhone 6 but not any iOS simulator and not the OS X SDK.

@1ec5 1ec5 added the iOS Mapbox Maps SDK for iOS label Jun 4, 2016
@jfirebaugh
Copy link
Contributor

Thanks, the bisect helped hugely. I was able to reproduce the issue, and found that reverting the default for line-round-limit to 1 resolved the issue.

a43940a changed the default to 1.05 because 1.05 is the correct value according to the style-spec. Apparently that value triggers latent bugs in gl-native however.

@jfirebaugh
Copy link
Contributor

Followups to #5258.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

2 participants