Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Android build SDK source 'arm-v5' compile error #5482

Closed
ghost opened this issue Jun 26, 2016 · 4 comments
Closed

Android build SDK source 'arm-v5' compile error #5482

ghost opened this issue Jun 26, 2016 · 4 comments
Labels
Android Mapbox Maps SDK for Android support

Comments

@ghost
Copy link

ghost commented Jun 26, 2016

Due to #5401 and #5402, I have to build android SDK source to change invalidateViewMarkersInBounds to show MarkerView. 'arm-v7' and 'x86' abis build success, but 'arm-v5' build error:

CXX(target) Release/obj.target/core/src/mbgl/annotation/annotation_source.o
In file included from ../../src/mbgl/annotation/annotation_source.cpp:1:
In file included from ../../src/mbgl/annotation/annotation_source.hpp:4:
In file included from ../../src/mbgl/style/source_impl.hpp:7:
In file included from ../../src/mbgl/tile/tile.hpp:8:
../../src/mbgl/renderer/bucket.hpp:53:35: error: chosen constructor is explicit
      in copy-initialization
    util::Atomic<bool> uploaded = { false };
                                  ^~~~~~~~~
../../src/mbgl/util/atomic.hpp:19:14: note: constructor declared here
    explicit Atomic(const T& data_) : data(data_) {}
             ^
In file included from ../../src/mbgl/annotation/symbol_annotation_impl.cpp:2:
In file included from ../../src/mbgl/annotation/annotation_tile.hpp:3:
In file included from ../../src/mbgl/tile/geometry_tile.hpp:3:
In file included from ../../src/mbgl/tile/tile.hpp:8:
../../src/mbgl/renderer/bucket.hpp:53:35: error: chosen constructor is explicit
      in copy-initialization
    util::Atomic<bool> uploaded = { false };
                                  ^~~~~~~~~
../../src/mbgl/util/atomic.hpp:19:14: note: constructor declared here
    explicit Atomic(const T& data_) : data(data_) {}
             ^
1 error generated.
platform/android/core.target.mk:285: recipe for target 'Release/obj.target/core/src/mbgl/annotation/annotation_source.o' failed
make[1]: *** [Release/obj.target/core/src/mbgl/annotation/annotation_source.o] Error 1
make[1]: *** Waiting for unfinished jobs....
1 error generated.
platform/android/core.target.mk:285: recipe for target 'Release/obj.target/core/src/mbgl/annotation/symbol_annotation_impl.o' failed
make[1]: *** [Release/obj.target/core/src/mbgl/annotation/symbol_annotation_impl.o] Error 1
make[1]: Leaving directory '/home/ubuntu/mapbox-gl-native/build/android-arm-v5'
Makefile:187: recipe for target 'android-lib-arm-v5' failed
make: *** [android-lib-arm-v5] Error 2

Any help? Thank you!

@tobrun
Copy link
Member

tobrun commented Jun 26, 2016

@CBiao
which make command are you using?
which gradle configuration are to get armeabi?

  • ndk tag?
  • apk split?

@tobrun tobrun added Android Mapbox Maps SDK for Android support labels Jun 26, 2016
@ghost
Copy link
Author

ghost commented Jun 26, 2016

I follow the https://github.com/mapbox/mapbox-gl-native/blob/master/INSTALL.md, make command is make android-lib-arm-v5 or make apackage. I'm new for this, am I doing right? No change to gradle configuration.

@tobrun
Copy link
Member

tobrun commented Jun 26, 2016

@CBiao
I can compile make android-lib-arm-v5 locally from release-android-4.1.0 without an issue.

Some follow up questions:

  • Why do you need to have an arm-v5?
  • Do you still have such a device?

As work around I would suggest building with make apackage -j4 BUILDTYPE=Release and ABI splits method if you want generate different apk for different abi. You are intersted in the armeabi one since that is compatible with armv5.

@ghost
Copy link
Author

ghost commented Jun 26, 2016

Finally, I found the reason! #5254

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android support
Projects
None yet
Development

No branches or pull requests

1 participant