Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Move Improve This Map to macOS SDK #5775

Closed
1ec5 opened this issue Jul 23, 2016 · 1 comment
Closed

Move Improve This Map to macOS SDK #5775

1ec5 opened this issue Jul 23, 2016 · 1 comment
Labels
good first issue Good for newcomers macOS Mapbox Maps SDK for macOS refactor
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jul 23, 2016

macosapp currently implements an Improve This Map item under the Help menu. This design is HIG-compliant, and it’s where users would expect to find this functionality. But developers shouldn’t have to reinvent this code in each application they write.

-[MapDocument giveFeedback:] should be implemented as an action on MGLMapView, so that developers can simply connect a menu item to the first responder’s -giveFeedback: action. Going a step further, maybe MGLMapView could append an Improve This Map item to the Help menu if one isn’t found. But that might be too aggressive and make too many assumptions about the host application, so let’s stick to just the action for now.

@1ec5 1ec5 added refactor macOS Mapbox Maps SDK for macOS labels Jul 23, 2016
@1ec5 1ec5 added the good first issue Good for newcomers label Oct 18, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Dec 9, 2016

Fixed in #5999 on the iOS SDK v3.4.0 / macOS SDK v0.3.0 release branch.

@1ec5 1ec5 closed this as completed Dec 9, 2016
@1ec5 1ec5 modified the milestone: macos-v0.3.0 Jan 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers macOS Mapbox Maps SDK for macOS refactor
Projects
None yet
Development

No branches or pull requests

1 participant