Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Test setting style properties to functions #6162

Closed
1ec5 opened this issue Aug 25, 2016 · 0 comments · Fixed by #6168
Closed

Test setting style properties to functions #6162

1ec5 opened this issue Aug 25, 2016 · 0 comments · Fixed by #6168
Assignees
@1ec5
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling tests
Milestone
ios-v3.4.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 25, 2016

The generated unit tests for style property setters and getters only exercise constant values, not functions. We should also test roundtripping functions too. That would’ve caught #6161.

/cc @frederoni
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS tests runtime styling labels Aug 25, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Aug 25, 2016
@1ec5 1ec5 self-assigned this Aug 26, 2016
@1ec5 1ec5 mentioned this issue Aug 26, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling tests
Projects
None yet
Milestone
ios-v3.4.0
Development

Successfully merging a pull request may close this issue.

Make style properties null-resettable; fix property function roundtripping mapbox/mapbox-gl-native
1 participant
@1ec5