-
Notifications
You must be signed in to change notification settings - Fork 1.3k
test-suite text-rotation-alignment tests are failing #6410
Comments
It looks like the root of this problem may be the use of |
Another issue is that native |
gl-native @ansis is there any reason for these not to be the same? Should it be 0.25 or 0.5? |
Another float vs integer discrepancy, this one going in the opposite direction: gl-js round trips collision box coordinates through Int16, while native keeps them floating point. |
I think they should be the same. I think 0.5 seems good. I think maybe it should be sharing a constant value with the minScale used in quads.js/cpp. But maybe they can be different and the CollisionTile version can be changed to 0 and eliminated completely? The only thing I think this affects is whether labels are visible when you quickly zoom out and underscale a tile. I don't think this should have any effect on placement in a tile's intended zoom range. |
Fixed by tweaking the test case. Using #3841 to track the above issues. |
Three
text-rotation-alignment
tests in the test-suite are rendering differently than gl-js. This is fallout of #6253 but appears to be related to the placement algorithm orsymbol-spacing
rather thantext-rotation-alignment
itself.text-rotation-alignment/{auto,map}-symbol-placement-line
These two tests are expected to produce the same output.
Expected (with/without collison debug):
Actual (with/without collison debug):
text-rotation-alignment/viewport-symbol-placement-line
Expected (with/without collison debug):
Actual (with/without collison debug):
The text was updated successfully, but these errors were encountered: