Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Cherry pick #6828 (Line-break ideographic text by character) #6996

Closed
tobrun opened this issue Nov 10, 2016 · 6 comments
Closed

Cherry pick #6828 (Line-break ideographic text by character) #6996

tobrun opened this issue Nov 10, 2016 · 6 comments
Labels
Android Mapbox Maps SDK for Android

Comments

@tobrun
Copy link
Member

tobrun commented Nov 10, 2016

Capturing from @1ec5 that Android will need a port of #6828. That PR allows to:

Automatically insert a line break after any supported Chinese, Japanese, or Yi character in a point-placed label as needed to stay within the text-max-width. Balance the lines unless non-ideographic text such as Latin letters are present.

Possibly also a port of mapbox/mapbox-gl-js#3438 is also needed.

Update: confusion from my end, we just need to cherry pick #6828 into the release-v4.2.0 branch. Using this ticket to track it.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Nov 10, 2016
@1ec5
Copy link
Contributor

1ec5 commented Nov 10, 2016

A port of mapbox/mapbox-gl-js#3438 is tracked in #1682. Neither #6828 nor #1682 requires any SDK work, other than to chery-pick the changes into the release branches.

@tobrun tobrun added this to the android-v4.2.0 milestone Nov 10, 2016
@tobrun
Copy link
Member Author

tobrun commented Nov 10, 2016

Commits were cherrypicked into release brach here, closing.

@tobrun tobrun closed this as completed Nov 10, 2016
@1ec5
Copy link
Contributor

1ec5 commented Nov 10, 2016

@tobrun, #6828 has not yet landed in master. I suggest backing out the cherry-picked commits and waiting until my PR passes a code review, because it'll get rebased before merging to master.

@1ec5 1ec5 reopened this Nov 10, 2016
@tobrun tobrun changed the title Line-break ideographic text by character Cherry pick: Line-break ideographic text by character Nov 11, 2016
@ivovandongen ivovandongen changed the title Cherry pick: Line-break ideographic text by character Cherry pick #6828 (Line-break ideographic text by character) Nov 11, 2016
@1ec5
Copy link
Contributor

1ec5 commented Nov 11, 2016

Looks like these commits got rewritten out of the branch already. 👍 Closing.

@1ec5 1ec5 closed this as completed Nov 11, 2016
@1ec5
Copy link
Contributor

1ec5 commented Nov 11, 2016

And reopening to track the eventual cherry-picking.

@jfirebaugh
Copy link
Contributor

Per chat, this feature is not required for the 4.2.0 release. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

3 participants