Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Standardize NSException names #7258

Closed
1ec5 opened this issue Dec 1, 2016 · 1 comment
Closed

Standardize NSException names #7258

1ec5 opened this issue Dec 1, 2016 · 1 comment
Assignees
Labels
documentation good first issue Good for newcomers iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS MapKit parity For feature parity with MapKit on iOS or macOS refactor

Comments

@1ec5
Copy link
Contributor

1ec5 commented Dec 1, 2016

Most of the NSExceptions we raise in the iOS and macOS SDKs are named with ad-hoc names such as “Value not handled”. Instead, we should either use one of the predefined exception names or define a string constant such as “MGLIdentifierCollisionException” in MGLTypes.h for use with these exceptions. This way, test code can more easily check for the exception with XCTAssertThrowsSpecificNamed(), and we could start adding notes about exception conditions in our method documentation.

/cc @incanus @frederoni

@fabian-guerra
Copy link
Contributor

Predefined exception names link update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation good first issue Good for newcomers iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS MapKit parity For feature parity with MapKit on iOS or macOS refactor
Projects
None yet
Development

No branches or pull requests

4 participants