This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Standardize NSException names #7258
Labels
documentation
good first issue
Good for newcomers
iOS
Mapbox Maps SDK for iOS
macOS
Mapbox Maps SDK for macOS
MapKit parity
For feature parity with MapKit on iOS or macOS
refactor
Milestone
Most of the NSExceptions we raise in the iOS and macOS SDKs are named with ad-hoc names such as “Value not handled”. Instead, we should either use one of the predefined exception names or define a string constant such as “MGLIdentifierCollisionException” in MGLTypes.h for use with these exceptions. This way, test code can more easily check for the exception with
XCTAssertThrowsSpecificNamed()
, and we could start adding notes about exception conditions in our method documentation./cc @incanus @frederoni
The text was updated successfully, but these errors were encountered: