Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

allow for nullable style layer predicate #7359

Closed
incanus opened this issue Dec 9, 2016 · 1 comment
Closed

allow for nullable style layer predicate #7359

incanus opened this issue Dec 9, 2016 · 1 comment
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Milestone

Comments

@incanus
Copy link
Contributor

incanus commented Dec 9, 2016

As with Core Data's NSFetchRequest, we should allow removal of a style layer predicate by setting it to nil. That other API also converts the TRUE (always on) predicate to nil upon roundtripping. Otherwise, there's not an obvious way to remove the predicate (Studio analog: filters) from a layer.

@incanus incanus added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling labels Dec 9, 2016
@incanus incanus added this to the ios-3.4.1 milestone Dec 9, 2016
@1ec5 1ec5 modified the milestones: ios-v3.4.0, ios-v3.4.1 Jan 24, 2017
@1ec5
Copy link
Contributor

1ec5 commented Jan 24, 2017

The predicate property was declared as nullable but setting it to nil didn’t work. This issue was reported again in #7704 and fixed in #7705, which made it into v3.4.0.

@1ec5 1ec5 closed this as completed Jan 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Development

No branches or pull requests

2 participants