Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove all deprecated methods #7575

Closed
zugaldia opened this issue Jan 2, 2017 · 2 comments
Closed

Remove all deprecated methods #7575

zugaldia opened this issue Jan 2, 2017 · 2 comments
Labels
Android Mapbox Maps SDK for Android good first issue Good for newcomers SEMVER-MAJOR Requires a major release according to Semantic Versioning rules

Comments

@zugaldia
Copy link
Member

zugaldia commented Jan 2, 2017

The next Android release cycle (5.x) will break SEMVER compatibility with previous versions. This is a good moment to remove all @Deprecated members from the codebase.

I'm still seeing 7 matches across 5 files:

image

@mapbox/android: Any good reasons to keep any of these methods around one more version?

@zugaldia zugaldia added Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules good first issue Good for newcomers labels Jan 2, 2017
@zugaldia zugaldia added this to the android-v5.0.0 milestone Jan 2, 2017
@tobrun
Copy link
Member

tobrun commented Jan 3, 2017

  • Deprecation Emerald-v8:
    • good to remove, it was replaced with outdoors in v9
  • Deprecation setStyleUrl:
    • there is some confusion related to this deprecation after discussing this with @cammace . This deprecation was valid if we didn't revert versioned styling methods in Style URLs in Android SDK #5193. If we decide to keep as-is implementations we should remove deprecation, if we would move to versioned style methods in Style.java we can remove the method fully.
  • Deprecation textureMode:
    • I wouldn't mind keeping this around until it starts blocking implementation of other features (eg. GLSurfaceView). We currently advice using the texture mode to workaround the issue of showing a map in a dialog MapView Overlay inside Dialog #6101 or if ViewMarker synchronisation should be more performant.
  • Deprecation dismiss tracking on gesture
    • need to double check but I think these are good to remove. They were replaced with methods specific to certain gestures for more granular control.
  • setAccessToken/getAccessToken in OfflineManager

@ghost
Copy link

ghost commented Jan 3, 2017

Before deprecated methods are removed, please take this issue into account:

#7584

@zugaldia zugaldia changed the title Remove all deprecate methods Remove all deprecated methods Jan 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android good first issue Good for newcomers SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Projects
None yet
Development

No branches or pull requests

2 participants