This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] - remove redudant log statements in native_map_view.cpp #7801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
5748-limit-logs-to-error-warning
branch
from
051ce27
to
a5eb3a9
Compare
|
Typo fixed, merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5748,
This PR removes unnecessary logging from
native_map_view.cppand limits logging to only errors and warnings. In normal cases the end developer will only see statements about webrequests as:I'm targetting to close #5748 with this PR but we still need to clean up logging from telemetry. I'm proposing to postpone that until we extract telemetry from the SDK. cc @zugaldia