Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Symbol layers render badly with zoom and property function #9201

Closed
aparlato opened this issue Jun 6, 2017 · 5 comments
Closed

Symbol layers render badly with zoom and property function #9201

aparlato opened this issue Jun 6, 2017 · 5 comments
Labels
iOS Mapbox Maps SDK for iOS needs information

Comments

@aparlato
Copy link

aparlato commented Jun 6, 2017

Platform: iOS
Mapbox SDK version: 3.52

image

☝️ lighter arrow icons are supposed to look like the other arrows but have a zoom and property function on opacity.

Steps to trigger behavior

  1. Create a zoom and property function on a symbol layer for icon or text
  2. Icon/text will appear white/lighter and blown out on mobile (if using two integer zoom stops, bug will be evident at higher zoom stop)

Expected behavior

Shows zoom and property function properly as written.

Actual behavior

Icon/text becomes white, pixelated, and/or blown out

@Guardiola31337 Guardiola31337 added the iOS Mapbox Maps SDK for iOS label Jun 7, 2017
@anandthakker
Copy link
Contributor

@aparlato could you include the function definition from the style JSON?

@aparlato
Copy link
Author

aparlato commented Jun 7, 2017

@anandthakker yea sorry!

Here's an example for a poi layer:

"text-opacity": {
                    "type": "interval",
                    "property": "localrank",
                    "stops": [
                        [
                            {
                                "zoom": 16,
                                "value": 0
                            },
                            1
                        ],
                        [
                            {
                                "zoom": 16,
                                "value": 14
                            },
                            1
                        ],
                        [
                            {
                                "zoom": 16,
                                "value": 15
                            },
                            0
                        ],
                        [
                            {
                                "zoom": 17,
                                "value": 0
                            },
                            1
                        ],
                        [
                            {
                                "zoom": 17,
                                "value": 14
                            },
                            1
                        ],
                        [
                            {
                                "zoom": 17,
                                "value": 15
                            },
                            1
                        ]
                    ]
                },
                "icon-opacity": {
                    "base": 1,
                    "type": "interval",
                    "property": "localrank",
                    "stops": [
                        [
                            {
                                "value": 0,
                                "zoom": 16
                            },
                            1
                        ],
                        [
                            {
                                "value": 14,
                                "zoom": 16
                            },
                            1
                        ],
                        [
                            {
                                "zoom": 16,
                                "value": 15
                            },
                            0
                        ],
                        [
                            {
                                "value": 0,
                                "zoom": 17
                            },
                            1
                        ],
                        [
                            {
                                "value": 14,
                                "zoom": 17
                            },
                            1
                        ],
                        [
                            {
                                "zoom": 17,
                                "value": 15
                            },
                            1
                        ]
                    ]
                }
            }
        }

I can only reproduce this exact behavior with the opacity properties on symbol layers although zoom and property functions in this version have issues in general which look like they've been resolved #8838 so maybe this is also resolved? I just realized that the current version is 3.54, not 3.52.

@nickidlugash
Copy link
Contributor

nickidlugash commented Jun 10, 2017

although zoom and property functions in this version have issues in general which look like they've been resolved #8838 so maybe this is also resolved?

This description:

Steps to trigger behavior

Create a zoom and property function on a symbol layer for icon or text

Icon/text will appear white/lighter and blown out on mobile (if using two integer zoom stops, bug will be evident at higher zoom stop)

Does sound a lot like #8613. @anandthakker do you think that PR should have resolved this issue?

@anandthakker
Copy link
Contributor

@nickidlugash ah - yeah, seems likely that that PR -- or the followup 3c23faf -- will have fixed it.

@jfirebaugh
Copy link
Contributor

Per above, assuming this is fixed; please let us know if not!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS needs information
Projects
None yet
Development

No branches or pull requests

6 participants